Implemented starknet_getClassAt
and starknet_getClassHashAt
#118
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
What is the current behavior?
get_class_hash_at
has been marked as TODO and does not return.get_class_at
has been marked as TODO and does not retrieve the correct contract ABI.output
field.L1_HANDLER
orCONSTRUCTOR
in their entrypoints.Resolves: #32 #33 #34
What is the new behavior?
starknet_getClassHashAt
retrieves the correct class hash.starknet_getClassAt
retrieves the correct class and ABI.output
field now has the correct values (was previously using the value of ABI functioninput
field).L1_HANDLER
orCONSTRUCTOR
is not defined.Does this introduce a breaking change?
No changes have been made to class or ABI storage, so there is no need to synchronize the database
Other information
starknet_getClass
,starknet_getClassHashAt
andstarknet_getClassAt
were briefly tested on the following classes:More tests will need to follow in Ditto.