Fixes #37959 - Allow optimized:false sync for ansible collections #11284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjha4
force-pushed
the
collection_optimized_sync
branch
from
b06f12e to
8b549ce
Compare
qcjames53
approved these changes
Feb 4, 2025
There was a problem hiding this comment.
Hi Samir! I was able to verify the changes to the pulp remote request occur during full smart proxy sync with ansible collections. The remote request remains the same for other content type/sync type combinations. The testing changes seem reasonable and I believe no further test coverage is necessary. ACKing!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes introduced in this pull request?
Ensure Full smart proxy Sync triggers non-optimised pulp sync for ansible collections.
Considerations taken when implementing this change?
See: #11168 for more context
Checked the ansible sync API here: https://pulpproject.org/pulp_ansible/restapi/#tag/Repositories:-Ansible/operation/repositories_ansible_ansible_sync
The optimize flag is supported here like yum, apt repos.
What are the testing steps for this pull request?