Fixes #9167: Fix chained scopes when using scoped_search in API #4965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Opened an issue against scoped search -- wvanbergen/scoped_search#120 |
jlsherrill
changed the title
|
[test] |
Scoped search claims to support being applied to a set of scopes via scopes.search_for. However, when multiple joins are used within the 'scopes' the last join wins in the prior format. To combat this, we apply the search_for first, which is itself a scope, and merge the scopes into that result.
ehelms
force-pushed
the
fixes-9167
branch
2 times, most recently
from
19b3bda to
25dda4c
Compare
|
ACK |
ehelms
added a commit
that referenced
this pull request
Feb 3, 2015
Fixes #9167: Fix chained scopes when using scoped_search in API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scoped search claims to support being applied to a set of scopes via
scopes.search_for. However, when multiple joins are used within the 'scopes'
the last join wins in the prior format. To combat this, we apply the
search_for first, which is itself a scope, and merge the scopes into
that result.