[SR][SR Tree] Update tree to use innerText #2090
Open
+6
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that we're using `a11y.srOnly` styling for the hidden aria descriptions, we don't need to use `textContent`, we can just use `innerText`. We also don't need the test for hidden content. Issue: none Test plan: `yarn jest packages/perseus-editor/src/widgets/interactive-graph-editor/components/interactive-graph-sr-tree.test.tsx`
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (1d19495) and published it to npm. You Example: yarn add @khanacademy/perseus@PR2090If you are working in Khan Academy's webapp, you can run: ./dev/tools/bump_perseus_version.sh -t PR2090 |
|
Size Change: -29 B (0%) Total Size: 1.28 MB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Now that we're using
a11y.srOnlystyling for the hiddenaria descriptions, we don't need to use
textContent, wecan just use
innerText.We also don't need the test for hidden content.
Issue: none
Test plan:
yarn jest packages/perseus-editor/src/widgets/interactive-graph-editor/components/interactive-graph-sr-tree.test.tsx