Skip to content

Commit

Permalink
svm: finish all queues in svm_pointer_passing (#2209)
Browse files Browse the repository at this point in the history
The `svm_pointer_passing` test has unflushed buffer unmap commands
queued, which a runtime might process after the `clSVMFree` calls at the
end of the test (through implicit flushing when destroying the queues at
e.g. program exit handlers).

This is only an issue when running the test with multiple devices.

However I think this was caused by a simple typo given the `clFinish`
was simply in the wrong block.
  • Loading branch information
karolherbst authored Jan 7, 2025
1 parent 86e0c23 commit 34feb6e
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions test_conformance/SVM/test_pointer_passing.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -127,10 +127,10 @@ REGISTER_TEST(svm_pointer_passing)
return -1;
}
}
}

error = clFinish(cmdq);
test_error(error, "clFinish failed");
error = clFinish(cmdq);
test_error(error, "clFinish failed");
}
}


Expand Down

0 comments on commit 34feb6e

Please sign in to comment.