Corrections for mutable arguments tests #1921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-added verification of device capabilities against mutable arguments -corrected fail of 2 tests with Construction Kit -general cleanup
EwanC
reviewed
Mar 19, 2024
There was a problem hiding this comment.
Since this PR does some cleanup, I'll comment here with a couple ideas of other cleanups I had in mind. But these should be done in a separate PR if we want to do them:
- Most command-buffer tests include that cl_ext.h include both
cl_extandcl.h, so I think we just needcl_ext.handcl.hcan be removed - https://github.com/KhronosGroup/OpenCL-Headers/blob/main/CL/cl_ext.h#L24 - The command-buffer CMake sets
set_gnulike_module_compile_flags("-Wno-sign-compare"), it would be nice if we could fix these warning and remove this.
...s/cl_khr_command_buffer/cl_khr_command_buffer_mutable_dispatch/mutable_command_arguments.cpp
Show resolved
Hide resolved
...s/cl_khr_command_buffer/cl_khr_command_buffer_mutable_dispatch/mutable_command_arguments.cpp
Outdated
Show resolved
Hide resolved
Do you think I should wait with mentioned cleanup PR until we will have all |
EwanC
reviewed
Mar 27, 2024
...s/cl_khr_command_buffer/cl_khr_command_buffer_mutable_dispatch/mutable_command_arguments.cpp
Outdated
Show resolved
Hide resolved
EwanC
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-added verification of device capabilities against mutable arguments
-general cleanup