Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix negative_create_command_buffer_device_does_not_support_out_of_ord… #2207

Merged
merged 2 commits into from
Jan 7, 2025
Merged

fix negative_create_command_buffer_device_does_not_support_out_of_ord… #2207

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
783e870
fix negative_create_command_buffer_device_does_not_support_out_of_ord…
rjodinchr Dec 26, 2024
da51c01
fix condition
rjodinchr Jan 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions test_conformance/extensions/cl_khr_command_buffer/basic_command_buffer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ BasicCommandBufferTest::BasicCommandBufferTest(cl_device_id device,
cl_command_queue queue)
: CommandBufferTestBase(device), context(context), queue(nullptr),
num_elements(0), simultaneous_use_support(false),
out_of_order_support(false),
out_of_order_support(false), queue_out_of_order_support(false),
// try to use simultaneous path by default
simultaneous_use_requested(true),
// due to simultaneous cases extend buffer size
Expand Down Expand Up @@ -57,7 +57,8 @@ bool BasicCommandBufferTest::Skip()
sizeof(queue_properties), &queue_properties,
NULL);
test_error(error, "Unable to query CL_QUEUE_PROPERTIES");

queue_out_of_order_support =
queue_properties & CL_QUEUE_OUT_OF_ORDER_EXEC_MODE_ENABLE;

// Query if device supports simultaneous use
cl_device_command_buffer_capabilities_khr capabilities;
Expand Down
1 change: 1 addition & 0 deletions test_conformance/extensions/cl_khr_command_buffer/basic_command_buffer.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@ struct BasicCommandBufferTest : CommandBufferTestBase
// Device support query results
bool simultaneous_use_support;
bool out_of_order_support;
bool queue_out_of_order_support;
bool device_side_enqueue_support;

// user request for simultaneous use
Expand Down
5 changes: 3 additions & 2 deletions test_conformance/extensions/cl_khr_command_buffer/negative_command_buffer_create.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,8 +289,9 @@ struct CreateCommandBufferDeviceDoesNotSupportOutOfOderQueue
{
BasicCommandBufferTest::Skip();
rjodinchr marked this conversation as resolved.
Show resolved Hide resolved

// If device supports out of order queues test should be skipped
return out_of_order_support != 0;
// If device does not support out of order queue or if device supports
// out of order command buffer test should be skipped
return !queue_out_of_order_support || out_of_order_support;
}

clCommandQueueWrapper out_of_order_queue;
Expand Down
Loading