Add Buffer Device Address chapter #275
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nhaehnle
reviewed
Sep 14, 2024
jeffbolznv
reviewed
Sep 14, 2024
| OpStore %ptr %obj Aligned 16 | ||
| ---- | ||
|
|
||
| This will match with the `VkMemoryRequirements::alignment` used to create the memory |
There was a problem hiding this comment.
No, this is a promise for how aligned this specific pointer is. And for GLSL, it's derived from the buffer_reference_alignment you put in the layout() and the offset in the structure.
There was a problem hiding this comment.
ok, I realize this is not worded right, but this is where I get a bit loss
so I understand passes in buffer_reference_alignment to set the Aligned in SPIR-V
vkGetBufferDeviceAddress is required to be aligned with VkMemoryRequirements::alignment
... I guess how would an app know this when they are creating their shader since they won't know the VkMemoryRequirements::alignment until runtime
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds some more details to the technical parts of
VK_KHR_buffer_device_address(mostly from the SPIR-V side, but didn't quite fit in the SPIRV-Guide scope)