Import extra data as custom properties #709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved generate_extras for the exporter into the common files and added set_extras for the importer to use. extras data on cameras, non-bone nodes, materials, and meshes is now imported and should round-trip succesfully as long as the Custom Properties option is checked when exporting.
julienduroure
added
enhancement
|
Next step: we need to manage bones too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves
generate_extrasfor the exporter into the common files and adds aset_extrasfor the importer to use.Extra data on the following objects is imported and can be round-tripped when the Custom Properties option for the exporter is checked
(This was requested at ksons/gltf-blender-importer#48)