Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't log a warning on a retriable RPCError #143

Merged
merged 1 commit into from
Nov 2, 2024
Merged

Don't log a warning on a retriable RPCError #143

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion rust/src/hdfs/proxy.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,10 +154,11 @@ impl NameServiceProxy {
}
// RPCError indicates the call was successfully attempted but had an error, so should be returned immediately
Err(HdfsError::RPCError(exception, msg)) if !Self::is_retriable(&exception) => {
warn!("{}: {}", exception, msg);
return Err(Self::convert_rpc_error(exception, msg));
}
Err(_) if attempts >= self.proxy_connections.len() - 1 => return result,
// Retriable error, do nothing and try the next connection
Err(HdfsError::RPCError(_, _)) => (),
Err(e) => {
warn!("{:?}", e);
}
Expand Down
Loading