This repository has been archived by the owner on Aug 5, 2024. It is now read-only.
Define index mappings from collection metadata #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leplatrem
force-pushed
the
8-collection-indexschema
branch
from
00755e2 to
a608cdd
Compare
Natim
approved these changes
May 26, 2017
tests/test_elasticsearch.py
Outdated
| "build": { | ||
| "properties": { | ||
| "date": {"type": "date", "format": "strict_date"}, | ||
| "id": {"type": "keyword"} |
tests/test_elasticsearch.py
Outdated
| "last_modified": {"type": "long"}, | ||
| "build": { | ||
| "properties": { | ||
| "date": {"type": "date", "format": "strict_date"}, |
tests/test_elasticsearch.py
Outdated
| mapping = self.get_mapping("bid", "cid") | ||
| assert mapping == { | ||
| "properties": { | ||
| "id": {"type": "keyword"}, |
There was a problem hiding this comment.
The string field is unsupported for indexes created in 5.x in favor of the text and keyword fields.
There was a problem hiding this comment.
Ok so maybe the ES running on Travis is not up-to-date enough. You should try using the trusty image to run tests on travis.
leplatrem
force-pushed
the
8-collection-indexschema
branch
from
1f70534 to
5d52d58
Compare
Natim
approved these changes
May 26, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #8
This is another approach to #36.
Since conversion from JSONSchema to ES mapping seems fragile. Let's take another curve and do something less smart but a lot simpler: read an explicit attribute
index:schemain the collection metadata.@glasserc @n1k0 @Natim @magopian Thoughts?