This repository has been archived by the owner on Jan 25, 2022. It is now read-only.
Do not use the count value from storage.get_all() #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterbe
approved these changes
Dec 7, 2018
There was a problem hiding this comment.
Some day we're going to have to replace that line with records = self.storage.list_all which will mean it won't need to make a separate SELECT COUNT(*) ... unnecessarily.
Perhaps we should leave a comment about that. Or just make a mental note to not forget about ALL storage.get_all uses in all other plugins we manage.
|
This is meant to support our fix for Kinto/kinto#1624, where we decided to only ever return records or total but not both at once. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.