count deleted by total_records fixes 1170 #1630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stloma
changed the title
|
I agree that this is a good fix and we should merge it -- why did you close it @stloma ? |
|
Darn, sorry, I was trying to clean up some of my older branches and deleted this by mistake :( |
|
Reopened from reflog, so it's the exact same changes that were already reviewed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1170
This issue was caused by relying on
offset < total_recordsto include theNext-Pageheader.This Boolean check makes sense when we're getting records since
total_recordsdoes not change andoffsetis incremented. When deleting, however,offsetis incremented andtotal_recordsis decremented, so theNext-Pageheader will stop being included when at roughly half of the beginning count oftotal_records.Also, I understand @glasserc is discussing how to handle
Total-Recordsin #1624 and this direct reliance onTotal-Recordsmight not make sense in the long-term. It still makes sense to me to push this change so you all can close out the original issue, but just thought I'd mention it in case you all have a different opinion on that.