add gif support, better grid view #20
Conversation
|
Hey, thanks for the pull request. I'll check this out as soon as I can. I am a bit strapped for time at the moment so expect a delay, but hopefully not a long one! |
There was a problem hiding this comment.
Hi! I've reviewed the behaviour of this within the client, and there are a few issues I'd like to bring up:
-
Due to a lack of elaboration, I am not entirely sure what you were aiming for the 'better grid view' change, but from what I have managed to observe, some functionality has been lost and the grid view no longer behaves the way it should and does not mimic vanilla Discord behaviour. I will attach an image below showing what I mean.
-
Although you've added GIF support, it does not meet the standard I have been aiming for. It does not mimic vanilla Discord behaviour and pause when the client window is unfocused. This is something I have planned to work on, hence why I have not added GIF support yet. I will attach video below to show what I mean.
4uaPfgdS2U_NOIZwOLGFm_Knew_edit.webm
Thanks once again for the pull request. Let me know what your plans are for this PR after this review.
No description provided.