Add TreeView component #96
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce a reusable TreeView component for hierarchical data display with expandable and collapsible nodes. Implemented the corresponding TreeViewScreen in the gallery for demonstration purposes. Includes a tree builder DSL for easy tree structure creation and ensures visual consistency with Fluent design.
kdroidFilter
changed the title
Introduced an optional `onClick` callback to `TreeElement` (both nodes and leaves) to handle custom click actions. Updated the tree builder DSL and composables to utilize this functionality, enabling more interactive tree components.
Modified the Tree component and TreeBuilder to include the expanded state as a parameter in the onClick callbacks. This allows nodes to differentiate actions based on their expanded or collapsed state, improving interactivity in the TreeView. Updated sample usage in TreeViewScreen to reflect these changes.
Sanlorng
reviewed
Dec 11, 2024
| @@ -0,0 +1,299 @@ | |||
| package com.konyaco.fluent.component | |||
|
|
|||
| import androidx.compose.animation.* | |||
Sanlorng
reviewed
Dec 11, 2024
| import androidx.compose.foundation.clickable | ||
| import androidx.compose.foundation.hoverable | ||
| import androidx.compose.foundation.interaction.MutableInteractionSource | ||
| import androidx.compose.foundation.layout.* |
Sanlorng
reviewed
Dec 11, 2024
| import androidx.compose.foundation.interaction.MutableInteractionSource | ||
| import androidx.compose.foundation.layout.* | ||
| import androidx.compose.foundation.shape.RoundedCornerShape | ||
| import androidx.compose.runtime.* |
Sanlorng
reviewed
Dec 11, 2024
| object TreeNodeDefaults { | ||
| @Stable | ||
| @Composable | ||
| fun defaultNodeColors( |
There was a problem hiding this comment.
default color token should reference figma file, see https://www.figma.com/community/file/1440832812269040007/windows-ui-kit
Sanlorng
reviewed
Dec 11, 2024
| } | ||
|
|
||
| @Composable | ||
| fun <T> TreeNodeColorScheme.schemeFor(state: VisualState): TreeNodeColor { |
There was a problem hiding this comment.
this function was exist in the VisualScheme.
Sanlorng
reviewed
Dec 11, 2024
There was a problem hiding this comment.
this components should be move to .collection package.
Sanlorng
reviewed
Dec 11, 2024
| val tree = remember { | ||
| buildTree { | ||
| node(data = "Root", onClick = { isExpanded -> | ||
| println("Root clicked, expanded: $isExpanded") |
There was a problem hiding this comment.
Using Section(output = { Text(outputContent)} ) to show sample click event.
|
Thank you for your contribution, but unfortunately, your PR cannot be merged at this time. Here are some reasons why:
I hope these suggestions help. Thank you for your understanding and cooperation! 😊 If you have any questions or need further assistance, please feel free to let me know. |
|
Thank you very much for taking the time to detail all my mistakes! :) I admit that I was not aware that there was a figma 😅, I was just inspired by https://bdlukaa.github.io/fluent_ui/#/navigation/tree_view |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a reusable TreeView component for hierarchical data display with expandable and collapsible nodes. Implemented the corresponding TreeViewScreen in the gallery for demonstration purposes. Includes a tree builder DSL for easy tree structure creation and ensures visual consistency with Fluent design.