-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move kotlinx.io.files package to a separate module #411
base: develop
Are you sure you want to change the base?
Conversation
JIC: there is one usage of |
In short term, the change should not break Ktor as long as a new artifact is added to dependencies. |
3f3ca2f
to
1e1544e
Compare
One of the questions still opened for me is the name of a new module. It should include something like WDYT? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
if we create a module with a different name, will we have two filesystem modules with a different name at the same time? |
Yes, we will.
It's always an option. |
Ok, so we'll have to use different package names anyway and having both the legacy and a new API inside a single module will ease the migration as we'll be able to supply deprecation with a meaningful replacement expression. |
b335f42
to
bf8393b
Compare
Ok, the current approach with the module (and its name) looks fine: we'll add a new API into it, that'll unlock easier migration compared to two separate artifacts. |
Move all filesystem-related functionality to a separate module.
While the library itself is getting closer to stabilization,
kotlinx.io.files
is getting closer to a trash bin.There's no way existing filesystem-related functionality will be stabilized. Instead it will be deprecated and replaced with a (hopefully) better API.
With a separate module, it'll be easier to manage different stability and depreciation levels.
Closes #319