[Core] Forbid Renaming ModelParts #12148
Conversation
|
What about update the hash map? |
We can make the Name() method const and update the implementation of the Rename method |
| std::string& Name() | ||
| { | ||
| return mName; | ||
| } | ||
|
|
There was a problem hiding this comment.
In this particualr case yes, it makes sense
There was a problem hiding this comment.
add_model_part_to_python.cpp:46:25: error: no match for 'operator=' (operand types are 'const std::string' {aka 'const std::__cxx11::basic_string<char>'} and 'const std::string' {aka 'const std::__cxx11::basic_string<char>'})Looks like python binding is a bit hardcoded
Is there a valid use case tho? I'd rather just remove the entire thing than move |
Well, i guess if the method was there is beacuse somone was using it |
|
@loumalouomega @KratosMultiphysics/technical-committee can you please come to a consensus on this one? |
|
I agree about making Name const, but I am.a bit afraid of not having any way of renting a smodelpart. Shouldnt we allow it at least from model? |
Description
ModelPartallows resetting its name, which breaks sub model part containers. These containers are hash maps that generate their hashes based on the model part's name. However, when aModelPartis renamed, the sub model part container of its parent doesn't update its hash map, which completely breaks access to sub model parts.Changelog
std::string& ModelPart::Name()(the mutable overload)Model::RenameModelPartand its corresponding test