Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix block_for_each Template Requirements #13062

Merged
merged 2 commits into from
Jan 31, 2025
Merged

Fix block_for_each Template Requirements #13062

merged 2 commits into from
Jan 31, 2025
+26 −1

Conversation

matekelemen
Copy link
Contributor

@matekelemen matekelemen commented Jan 30, 2025 •
edited
Loading

block_for_each has quite a few overloads even though all of them are templates. To distinguish between them, some need a bit of enable_if magic to make the compiler choose the correct one.

I had a template bracketing error in one of these enable_ifs that manifested when the deduced template parameter was a container whose iterator is a raw pointer.

oopsies.

@matekelemen matekelemen added C++ Parallel-SMP Shared memory parallelism with OpenMP or C++ Threads Bugfix labels Jan 30, 2025
@matekelemen matekelemen self-assigned this Jan 30, 2025
@matekelemen matekelemen requested a review from a team as a code owner January 30, 2025 00:11
loumalouomega
loumalouomega previously approved these changes Jan 30, 2025
View reviewed changes
Copy link
Member

@loumalouomega loumalouomega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI passes, I am OK

@loumalouomega
Copy link
Member

@roigcarlo take a look

@philbucher
Copy link
Member

can you add a test?

@matekelemen
Copy link
Contributor Author

can you add a test?

@philbucher done

@matekelemen matekelemen merged commit 89e5658 into master Jan 31, 2025
11 checks passed
@matekelemen matekelemen deleted the core/parallel-enable-if branch January 31, 2025 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philbucher philbucher philbucher approved these changes

@loumalouomega loumalouomega loumalouomega left review comments

@sunethwarna sunethwarna Awaiting requested review from sunethwarna

Assignees

@matekelemen matekelemen

Labels
Bugfix C++ Kratos Core Parallel-SMP Shared memory parallelism with OpenMP or C++ Threads
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matekelemen @loumalouomega @philbucher