[Core] Brep Surface - trimmed integration (Part 1 - Outer loop) #13072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matekelemen
reviewed
Jan 30, 2025
There was a problem hiding this comment.
I agree with this change 👍
There was a problem hiding this comment.
I agree with the changes but we need to be sure that the chosen tolerances are robust enough. I think the tests for this will be provided in the 3rd PR regarding trimming, won't they?
There was a problem hiding this comment.
How rigid is your function interface? If not much, you could pass in the tolerance as an argument.
There was a problem hiding this comment.
Yes, all the stuff with the tolerances will be discussed in other PR: This one just remedies the general problem related the outer trimming.
Co-authored-by: Máté Kelemen <[email protected]>
juancamarotti
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
This is the first part of the PR series to fix the problem related to the trimmed integration in the IGA application.
This PR corrects some issues for the outer loop trimming.
🆕 Changelog
clip_area(to avoid a case wheresolution.size() == 0)The inner trimming and test cases will be elaborated on in the next PRs.