Fix Matrix Value Types in SparseMatrixMultiplicationUtility
#13079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loumalouomega
previously approved these changes
Jan 31, 2025
|
Nope, I just want to build a single precision system. |
…into core/fix-matrix-value-type
|
This was more difficult than I initially imagined; sry @loumalouomega can you take a look again plz? |
loumalouomega
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some functions in
SparseMultiplicationUtilityassumed the value type of the input matrices were alwaysdoubleeven though they are templated.This PR replaces these assumptions with the
value_typealias of the input matrices.