registry: Use txt registry for owned records #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikenairn
force-pushed
the
48_use_txt_registry
branch
2 times, most recently
from
f2a112e to
204b52b
Compare
mikenairn
changed the title
We will be using a forked version of external-dns for the time being and will track the latest release version (v0.14.0) + kuadrant related changes in https://github.com/Kuadrant/external-dns/tree/v0.14.0_kuadrant
mikenairn
force-pushed
the
48_use_txt_registry
branch
from
204b52b to
97e32be
Compare
Use the TXT Registry when an `ownerID` is specified for a record being processed. Adds an optional field `ownerID` to the DNSRecord spec. This is immutable since changing it after initial creation will likely not result in desirable behaviour. Update e2e tests to verify contents of zone after record creation.
Add `local-cleanup` make target which deletes the development kind cluster created by `make local-setup`.
mikenairn
force-pushed
the
48_use_txt_registry
branch
from
97e32be to
00b6621
Compare
philbrookes
reviewed
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the TXT Registry when an
ownerIDis specified for a record being processed. Adds an optional fieldownerIDto the DNSRecord spec. This is immutable since changing it after initial creation will likely not result in desirable behaviour.Requires:
closes #48