fix: DNSRecord status updates on errors #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikenairn
force-pushed
the
fix_status_update_on_errors
branch
from
6ac685b to
6c7b5ea
Compare
mikenairn
force-pushed
the
fix_status_update_on_errors
branch
from
54e5d83 to
992b321
Compare
philbrookes
reviewed
Apr 30, 2024
mikenairn
force-pushed
the
fix_status_update_on_errors
branch
from
992b321 to
19ffb98
Compare
philbrookes
reviewed
Apr 30, 2024
philbrookes
reviewed
Apr 30, 2024
mikenairn
force-pushed
the
fix_status_update_on_errors
branch
from
19ffb98 to
f5d2004
Compare
Fixes an issue where the DNSRecord status was incorrectly being updated on every reconciliation even when errors were occuring causing the reconciler to go into a never ending loop and never exponentially backoff as would be expected in an error case. dnsrecord controller: * Reset WriteCounter, ValidFor, QueuedAt and QueuedFor to previous values before update on error. Updates e2e tests: * Move check for zone records to before checking nameservers since it will fail quicker. * Reduce wait time for records being ready 5 -> 1 minute.
Anywhere the plan is manipulating endpoints needs to work with a copy to ensure that it doesn't change the passed in spec value. Was causing an issue where the status was being updated incorrectly due to the dnsrecord spec endpoints changing.
mikenairn
force-pushed
the
fix_status_update_on_errors
branch
from
f5d2004 to
22554f2
Compare
mikenairn
commented
Apr 30, 2024
| current.Status.ValidFor = previous.Status.ValidFor | ||
| current.Status.QueuedAt = previous.Status.QueuedAt | ||
| current.Status.QueuedFor = previous.Status.QueuedFor | ||
| } |
There was a problem hiding this comment.
If we get an error ensure that these status fields are not updated from their previous values
philbrookes
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #96
Fixes an issue where the DNSRecord status was incorrectly being updated on every reconciliation even when errors were occuring causing the reconciler to go into a never ending loop and never exponentially backoff as would be expected in an error case.