Correct perms for dist folder, explicit copy & remove old .dockerignore #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jasonmadigan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jasonmadigan
force-pushed
the
dockerbuild-issue
branch
from
425c9c6 to
aa300ee
Compare
…re. add test for file existence Signed-off-by: Jason Madigan <[email protected]>
jasonmadigan
force-pushed
the
dockerbuild-issue
branch
from
5a1c27e to
bd0d87e
Compare
|
verified on cluster |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
quay.io/kuadrant/console-plugin:v0.0.14 sh-5.1$ sh-5.1$ cd /usr/share/nginx/html sh-5.1$ ls 1040-chunk-d134c6b1ec0f400587f0.min.js 3992-chunk-d536915a08a22b8fb859.min.js 6202-chunk-9961a854c01c5d1b068b.min.js.LICENSE.txt 8906-chunk-3f1147347760b551b057.min.js 1240-chunk-4ffca4814c3aa6892308.min.js 404.html 6279-chunk-38c0b4d4acbae5f464f4.min.js 8906-chunk-3f1147347760b551b057.min.js.LICENSE.txt 1281-chunk-0344c707cb195d3e6069.min.js 416-chunk-364e702457e1ff8b2b14.min.js 6291-chunk-4ddd722ea715b0f18cdf.min.js 8994-chunk-4cdc36ef2b3b333dbcd8.min.js 1283-chunk-b8c04937acc7e321c59b.min.js 4194-chunk-7630c4e6aa9458971c6b.min.js 6291-chunk-4ddd722ea715b0f18cdf.min.js.LICENSE.txt 8994-chunk-4cdc36ef2b3b333dbcd8.min.js.LICENSE.txtSince around 0.0.15 or so, our builds have been missing a bunch of files that should have been copied to dist. Since the base image change, didn't spot a silently failing copy because of perms. Have addressed the perms issue, and fixed the build. Testing locally, the yarn dist / webpack steps now work correctly.
We'll release this as v0.0.17 (and likely nuke the two previous "releases").
After this change: