Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable specification of the container engine for catalog builds #1124

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

trepel
Copy link
Contributor

@trepel trepel commented Jan 17, 2025

Overview

Makefile defines CONTAINER_ENGINE env var setting 'docker' as a default value. This env var should be used rather than having 'docker' hard-coded.

Verification Steps

make catalog-build
CONTAINER_ENGINE=docker make catalog-build
CONTAINER_ENGINE=podman make catalog-build

The output depends on your docker/podman config but if you have both installed and configured the commands should work. If you e.g. do not use docker then you can see something along the lines of
ERROR: Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running?

Copy link
Contributor

@Boomatang Boomatang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I don't have docker installed, but on main this failed to find docker when the env var was set. On this branch it worked.

@trepel trepel merged commit a1ca1d0 into Kuadrant:main Jan 23, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants