Merge pull request #139 from Kylemc1413/fix/null-hash

Fix an issue when retrieving extra data in the editor

source/SongCore/Collections.cs

@@ -80,6 +80,7 @@ internal static void AddExtraSongData(string hash, string path, string rawSongDa
 
             if (!beatmapLevel.hasPrecalculatedData)
             {
+                // TODO: Will be null in the editor due to levelID being "custom_level_CustomLevel".
                 songData = RetrieveExtraSongData(Hashing.GetCustomLevelHash(beatmapLevel));
             }
 

source/SongCore/HarmonyPatches/CosmeticCharacteristicsPatch.cs

@@ -32,7 +32,7 @@ private void SetCosmeticCharacteristic(BeatmapCharacteristicSegmentedControlCont
                 return;
             }
 
-            var extraSongData = Collections.RetrieveExtraSongData(Hashing.GetCustomLevelHash(beatmapLevel)!);
+            var extraSongData = Collections.RetrieveExtraSongData(Hashing.GetCustomLevelHash(beatmapLevel));
             if (extraSongData?._characteristicDetails == null || extraSongData._characteristicDetails.Length == 0)
             {
                 return;

source/SongCore/Utilities/Hashing.cs

@@ -119,18 +119,18 @@ private static bool GetCachedSongData(string customLevelPath, out long directory
             return false;
         }
 
-        public static string? GetCustomLevelHash(BeatmapLevel level)
+        public static string GetCustomLevelHash(BeatmapLevel level)
         {
             var standardLevelInfoSaveData = Collections.GetStandardLevelInfoSaveData(level.levelID);
             if (standardLevelInfoSaveData == null)
             {
-                return null;
+                return string.Empty;
             }
 
             var customLevelPath = Collections.GetCustomLevelPath(level.levelID);
             if (string.IsNullOrEmpty(customLevelPath))
             {
-                return null;
+                return string.Empty;
             }
 
             return GetCustomLevelHash(customLevelPath, standardLevelInfoSaveData.difficultyBeatmapSets);