Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rse viewer #63

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from
Open

Rse viewer #63

wants to merge 10 commits into from

Conversation

erezcoh4
Copy link

@erezcoh4 erezcoh4 commented Aug 7, 2016

No description provided.

@erezcoh4
Copy link
Author

erezcoh4 commented Aug 7, 2016

refined R/S/E navigation and synced ROI with RGB images

@drinkingkazu
Copy link

Should we evaluate this branch? Help resolving conflicts etc.?
@erezcoh4 feel free to tag others as participants. I tag myself. If you can specify some specific things (like I asked above) then I'm happy to help.

@vgenty
Copy link
Member

vgenty commented Aug 9, 2016

Yes we should evaluate, I think i see some binary files committed to this branch such as w/ this commit 417ea31. In addition there are some hard coded paths we need to address present in this commit 8add435

@vgenty vgenty assigned vgenty and unassigned vgenty Aug 9, 2016
@erezcoh4
Copy link
Author

erezcoh4 commented Aug 9, 2016

thanks @vgenty and @drinkingkazu
the hard-coded paths make it easier for me to load the (same) ROI file i use every time.
I plan (when i have time....) to add a loading widget that will prevent the user from having to type the full path every time he wants to load the ROI file, and change the production widget to a pop-up list. does this make sense?

@twongjirad
Copy link
Member

though I understand the hardcoded paths are useful to you, develop is for everyone. and everyone uses the ROI tools for hand-scanning. in order to merge into develop, those need to be removed.

@erezcoh4
Copy link
Author

hhh, i didn't mean that we should keep these paths of course... just meant to explain myself; i'll remove them of course... sorry

@twongjirad
Copy link
Member

Oh, sorry! I misunderstood. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants