-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/lit 4124 js sdk naga fix bls wasm #762
Open
Ansonhkg
wants to merge
19
commits into
feature/lit-3748-naga
Choose a base branch
from
feature/lit-4124-js-sdk-naga-fix-bls-wasm
base: feature/lit-3748-naga
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feature/lit 4124 js sdk naga fix bls wasm #762
Ansonhkg
wants to merge
19
commits into
feature/lit-3748-naga
from
feature/lit-4124-js-sdk-naga-fix-bls-wasm
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ansonhkg
requested review from
mikelodder7,
glitch003,
GTC6244 and
DashKash54
January 11, 2025 02:38
mikelodder7
approved these changes
Jan 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as long as it works in the JS side.
… usage - Also send `nodeSet` to `sign_session_key` endpoint as it is required - Fixed typo on name of wasm method for `ecdsaCombineAndVerify` (was previously unused)
…a-dev-support-with-rust-toolchain add rust-toolchain.toml so we autoinstall some necessary rust stuff
…a-add-naga-dev-support feat: add naga dev support
…ithub.com/LIT-Protocol/js-sdk into feature/lit-4124-js-sdk-naga-fix-bls-wasm
Closing this soon in favour of feat/naga-fix-bls-wasm-cleanup |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
Fix BLS