Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the 'hipEventDisableSystemFence' flag #183

Open
wants to merge 1 commit into
base: hydrogen
Choose a base branch
from
Open

Remove the 'hipEventDisableSystemFence' flag #183

wants to merge 1 commit into from

Conversation

benson31
Copy link
Collaborator

Performance implications are not yet understood (do, however, remember we cut out a bunch of superfluous event recording).

@benson31 benson31 requested review from ndryden and tbennun August 29, 2024 16:21
ndryden
ndryden approved these changes Aug 29, 2024
View reviewed changes
Copy link
Collaborator

@ndryden ndryden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but let's understand the implications before merging.

tbennun
tbennun reviewed Aug 29, 2024
View reviewed changes
Copy link

@tbennun tbennun left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let’s discuss

@benson31 benson31 requested a review from bvanessen August 29, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndryden ndryden ndryden approved these changes

@bvanessen bvanessen bvanessen approved these changes

@tbennun tbennun tbennun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@benson31 @ndryden @bvanessen @tbennun