[WIP] Version 0.8.0 release aka ECMech v0.4.0 compatibility #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to some issues with ADIOS2 segfaulting on some very large simulation data sets when running the new Rust based python light-up scripts, I needed to port those capabilities to run during the simulations. It was a fairly straight-forward port (still need to compile) as the Rust to C++ conversion was fairly simple... I still like the Rust version a bit more just as the code is nicer, and it works so well with python...
Will definitely need to actually iterate on things some more, but I needed to do lots of refactoring / fixing tons of bugs in the code :/ I really wanted to avoid having everything in the header file just as that complicates things but it turns out that once again that was the easiet thing to get things working again... Obviously this also required some additional changes elsewhere so that system_driver.hpp wasn't dragging everything from the lightup header into its header and then polluting other pieces of code. I will also probably need to convert more things from std::array and double[] to mfem::Vectors just to be able to move things over to the gpu.
Ran down a few bugs in the lattice calculations and find fiber calculations Also added all the stuff needed in the options.toml file. The sample direction aspect of things might still need to be fixed but tested it with y and z directions.
Refactored some of the code such that we can now work with v0.4.0 and also leverage a lot of new underlying code in ECMech to simplify a ton of our options / model set-up code.We can run any model supported by ECMech in it's cases without having to manually add the code in ExaConstit. The upside of this is that our compile times are now a lot faster and maintanence of the code is a lot simpler. The downsides are that users need to take advantage of the new shortcut key in the options file which has less than ideal naming conventions for models. Additionally, we needed to remove the ability to calculate and output the plastic deformation rate tensor as we currently don't have access to the slip system class in ECMech as we now make use of a base class.
Picked up a number of bug fixes I had in another local branch and migrated them over here to ensure they were captured. Next clang was throwing a bunch of warnings to me that seemed like the appropriate time to fix as well. Finally brought over an "experimental" feature we've been using for a lot of single crystal work to make it super simple to model uniaxial tension / compression in the z direction.
Overall mainly build system changes but there were some minor changes to update the RAJA forall execution type for sequential runs as the loop_exec type is deprecated in more modern RAJA versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still a work in progress but this will eventually change the version of ECMech that ExaConstit is compatible with from v0.3.4 to v0.4.0.
Additionally this will add support for insitu calculations of light-up like functions that are useful to get out lattice strain type values.
Will build on this as I get time and test this on more platforms than what I've gotten to so far.