Handle hierarchical smoothness for Matern #239
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igoumiri
commented
Sep 4, 2024
| _backend_05_fn: Callable = _matern_05_fn, | ||
| _backend_15_fn: Callable = _matern_15_fn, | ||
| _backend_25_fn: Callable = _matern_25_fn, | ||
| _backend_inf_fn: Callable = _matern_inf_fn, | ||
| _backend_gen_fn: Callable = _matern_gen_fn, | ||
| ): | ||
| if smoothness.fixed() is True: |
There was a problem hiding this comment.
This was crazy. Numpy functions return np.bool_ so comparisons with == work but is fail. That took me a while to debug.
igoumiri
commented
Sep 4, 2024
| from MuyGPyS.gp.hyperparameter.experimental import ( | ||
| HierarchicalParam, | ||
| NamedHierarchicalParam, | ||
| ) | ||
| from MuyGPyS.gp.kernels import KernelFn | ||
|
|
||
|
|
||
| def _set_matern_fn( |
There was a problem hiding this comment.
Part of the problem is that hierarchical parameters require batch_features to be evaluated, and we don't have them at init time. I'm not sure if we should just default to _backend_gen_fn or if we need to evaluate and map _set_matern_fn to each smoothness value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
work in progress. Tests are still failing.