Clang-format support #117
Merged
Clang-format support #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chapman39
reviewed
Dec 26, 2024
| @@ -142,7 +142,7 @@ class Tribol(CachedCMakePackage, CudaPackage, ROCmPackage): | |||
| depends_on("python", when="+devtools") | |||
| depends_on("py-shroud", when="+devtools+fortran") | |||
| depends_on("py-sphinx", when="+devtools") | |||
| depends_on("llvm+clang@10.0.0", when="+devtools", type="build") | |||
| depends_on("llvm+clang@14:", when="+devtools", type="build") | |||
There was a problem hiding this comment.
Suggested change
| depends_on("llvm+clang@14:", when="+devtools", type="build") | |
| depends_on("llvm+clang@14", when="+devtools", type="build") |
i would recommend this as major clang-format versions produce different style
|
This one should be good to go now |
srwopschall
approved these changes
Jan 6, 2025
There was a problem hiding this comment.
@ebchin - Thanks for tackling this. Looks great. Test 'make style' and add spacing formatting as discussed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.clang-formatcustom style (based on Serac).clang-formaton all header and source files insrcclang-format14 upon pushing to GitHubdevelop, leaving a comment/stylein the PR should runclang-formatto apply style to code (see this Serac PR for more details)