Skip to content

Commit

Permalink
Merge branch 'develop' into feature/single_node_check
Browse files Browse the repository at this point in the history
  • Loading branch information
pearce8 authored Jan 6, 2025
2 parents 9828525 + fbfce03 commit 9d17de6
Show file tree
Hide file tree
Showing 5 changed files with 40 additions and 3 deletions.
1 change: 0 additions & 1 deletion .github/workflows/license.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ jobs:
uses: actions/setup-python@0b93645e9fea7318ecaed2b359559ac225c90a2b
with:
python-version: '3.11'
cache: 'pip'

- name: Verify license headers
run: |
Expand Down
2 changes: 1 addition & 1 deletion docs/generate-benchmark-list.py
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ def main(workspace):
benchmarks = list()
benchpark_benchmarks(benchmarks)

f = "../tags.yaml"
f = "../taxonomy.yaml"
with open(f, "r") as stream:
try:
data = yaml.safe_load(stream)
Expand Down
2 changes: 1 addition & 1 deletion lib/main.py
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ def benchpark_benchmarks():


def benchpark_get_tags():
f = benchpark.paths.benchpark_root / "tags.yaml"
f = benchpark.paths.benchpark_root / "taxonomy.yaml"
tags = []

with open(f, "r") as stream:
Expand Down
38 changes: 38 additions & 0 deletions pull_request_template.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
## Description

FIXME:Provide a short summary of the change. Please also include relevant
motivation and context.

Dependencies: FIXME:Add a list of any dependencies.

Fixes issue(s): FIXME:Add list of relevant issues.

## Type of Change

- { } Adding a system, benchmark, or experiment
- { } Modifying an existing system, benchmark, or experiment
- { } Documentation update
- { } Build/CI update
- { } Benchpark core functionality

## Checklist:

If adding/modifying a system:
- { } Create a new directory for the system and a new `system.py` file
- { } Add a new dry run unit test in `.github/workflows`
- { } System appears in System Specifications table in docs catalogue section

If adding/modifying a benchpark:
- { } Add a new `application.py` and (maybe) `package.py` under a new directory
for this benchmark
- { } Configure an experiment
- { } Benchmark appears in Benchmarks and Experiments table in docs catalogue
section

If adding/modifying a experiment:
- { } Extend `experiment.py` under existing directory for specific benchmark
- { } Define a single node and multi-node experiments

If adding/modifying core functionality:
- { } Update docs
- { } Update `.github/workflows` and `.gitlab/ci` unit tests (if needed)
File renamed without changes.

0 comments on commit 9d17de6

Please sign in to comment.