Fix/transports internal msgs #264
Open
+307
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rom external sources or optionally from self.
… avoid redirecting messages that just arrived from outside.
…in parameter is updated.
…ecting messages that just arrived from outside.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tasks now can optionally loopback all IMC messages.
Tasks loopback "external" IMC messages, as they may be the "target".
Transports ignore "external" IMC messages on consume(const IMC::Message* msg) as they only need to forward "internal" messages, the IMC messages they need, that might be "external" are consumed in specific consume(...) methods.
Note: Transports are not able to forward IMC messages that they "subscribed" (bind<...>(this)).
TODO: forgot to add Loopback Internal Messages = true to [Transports.HTTP] parameters (on etc/common/transports.ini/ line 68).