Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to Wiremock - only rename file that exists, and update Wiremo… #156

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

IWHarvey
Copy link
Collaborator

@IWHarvey IWHarvey commented Jun 13, 2024

  • What kind of change does this PR introduce (Bug fix, feature, docs update, ...)?
    Commodity update and bug fix

  • What is the current behavior?
    Wiremock is very out of date.
    A wiremock commodity with a folder of WM configuration fails to provision with "mv: cannot stat '/wiremock/mappings/wiremock-fragment.json': No such file or directory"

  • What is the new behavior (if this is a feature change)?
    Wiremock is up to date
    Doesn't fall over when provisioning with a folder of WM config and no wiremock-fragment.json

  • Does this PR introduce a breaking change? If so, what actions will users need to take in order to regain compatibility?
    Possible with the WM upgrade but was unable to test as none of my wiremock configuration worked at all with 2.x

Checklists

All submissions

  • Have you followed the guidelines in our Contributing document?
  • Is this PR targeting the develop branch, and the branch rebased with commits squashed if needed?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New feature and bug fix submissions

  • Has your submission been tested locally?
  • Has documentation such as the README been updated if necessary?
  • Have you linted your new code (using rubocop and markdownlint), and are not introducing any new offenses?

@sichapman sichapman merged commit 016fef4 into develop Jun 13, 2024
1 of 3 checks passed
@sichapman sichapman deleted the wiremock_fix branch June 13, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants