Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added elasticsearch7 commodity #159

Merged
merged 2 commits into from
Oct 7, 2024

Conversation

james-r-hmlr
Copy link
Contributor

  • What kind of change does this PR introduce (Bug fix, feature, docs update, ...)?
    Adds Elastic Search 7 as an optional commodity (Elastic Search 5 still exists as separate commodity)

  • What is the current behavior?
    'elasticsearch7' can be added to an application's configuration.yml file to automatically spin up a Elastic Search 7 container

  • What is the new behavior (if this is a feature change)?
    Existing Elastic Search 5 commodity should remain unchanged

Checklists

All submissions

  • Have you followed the guidelines in our Contributing document?
  • Is this PR targeting the develop branch, and the branch rebased with commits squashed if needed?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New feature and bug fix submissions

  • Has your submission been tested locally?
  • Has documentation such as the README been updated if necessary?
  • Have you linted your new code (using rubocop and markdownlint), and are not introducing any new offenses?

@sichapman sichapman marked this pull request as ready for review October 7, 2024 15:08
@sichapman sichapman merged commit 6d76a77 into LandRegistry:develop Oct 7, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants