-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Assign location to tokens #150
Conversation
- That allow implement parsers which indirectly span across multiple files, like C/C++ Related: LanguageDev#34 (comment)
This PR can be considered
Would like to start talking about directions. |
Also I did not attempt to make API without breaking changes. Have to know opinion on the matter, and is breaking changes possible |
I come to conclusion that features of SourceFile which trigger inconsistent behaviour is overkill. Would be good if SourceFile would no longer be derived from TextWriter, and for backward compatibility there either other class with similar functionality, or make breaking change. |
Will try to summon @LPeter1997 to discuss things |
Sorry for the super-delayed reply. I'll try to get to this in a week or so. I'm sadly working on other things and I have many-many things left here to tidy up. |
Restore backward compatible constructors for generated lexers and restore changes in tests.
@ForNeVeR I manage to change PR to the state where it does not have source breaking changes, and only binary one. What do you think, should I go further and make it binary compatible (which ideally proper way) |
I'd say that Yoakke shouldn't care about binary compatibility for now. |
Related: #34 (comment)