feat: slashing release #311

stevennevins · 2024-10-17T19:24:34Z

No description provided.

* chore: update mock contracts with latest interfaces

* chore: checkout migration branch * feat: implement migration function * chore: update to release branch * feat: operator set creation for each quorum number * feat: migration with merge sorted array of operators and their quorums * feat: operator set migration working * chore: revert change from testing * chore: revert change from testing * chore: remove extra logging and commented out asserts * chore: remove unused file * fix: remove console logs * refactor: to view functions * chore: nit and remove unneeded function * fix: remove duplication of looping for all the operators * chore: remove comment * feat: allow migrating in two transactions * feat: finalization of migration * chore: use string errors and fix migration issues * chore: rename * feat: use library for merge sort * test: fuzz view function

* chore: checkout migration branch * feat: implement migration function * chore: update to release branch * feat: operator set creation for each quorum number * feat: migration with merge sorted array of operators and their quorums * feat: operator set migration working * chore: revert change from testing * chore: revert change from testing * chore: remove extra logging and commented out asserts * chore: remove unused file * fix: remove console logs * feat: create quorum post operator set migration * test(wip): create quorum test adds new operator set * test: migration create quorum * refactor: to view functions * chore: nit and remove unneeded function * fix: remove duplication of looping for all the operators * chore: remove comment * feat: allow migrating in two transactions * feat: finalization of migration * chore: use string errors and fix migration issues * chore: rename * feat: use library for merge sort * test: fuzz view function * fix: updates from merge * chore: use interface

* chore: update to latest eigenlayer-contracts feat/operator-set-release * chore: add method to mock

* feat: update stakes handle direct deregistration on AVSDirectory * test: update stake for quorum if operator directly unregistered from the AVSDirectory * chore: simplify setup * chore: simplify setup * chore: make service manager immutable on stakeRegistry

* feat: register and deregister to operator sets * fix: bytecode wrangling * chore: shorter errors to reduce bytecode * test: register after migration * chore: remove stale todos * chore: add back commented line * chore: remain consistent with m2 events * fix: side effect of merge from _deregister function * fix: bytecode massaging * chore: rename for clarity * chore: remove comments and whitespace * docs: add natspec to the library

* feat: upgrade and test pre prod upgrade and migration * fix: add param introduced in merge

* chore: bump to slashing branch * chore: bump compiler version * fix: dep interface changes * fix: compiler errors from interface changes and type changes * fix: compiler errors * chore: bump dependencies * chore: bump core dependency and resolve issues * chore: bump core dependency and fix compiler errors * feat: integrate AllocationManager * feat: add a slashing permission to the service manager * chore: remove unneeded casting * feat: implement a slasher permission and forward call to AllocationManager * feat: add simiple slasher starting point * chore: bump slashing magnitudes * chore: bump core slashing-magnitudes branch

* chore: bump to slashing branch * chore: bump compiler version * fix: dep interface changes * fix: compiler errors from interface changes and type changes * fix: compiler errors * chore: bump dependencies * chore: bump core dependency and resolve issues * chore: bump core dependency and fix compiler errors * feat: integrate AllocationManager * feat: add a slashing permission to the service manager * chore: remove unneeded casting * feat: implement a slasher permission and forward call to AllocationManager * feat: add simiple slasher starting point * feat: slashers * chore: change around slashed event * fix: call dm * feat: add proposal mechanism for updating slasher * fix: set to completed instead of delete * chore: use struct instead of params directly * chore: clean up params more * chore: simplify and organize files * chore: cleanup logic and couple event with internal func * fix: pass correct params * chore: organize and add interface * chore: nits * chore: cleanup more nits * fix: storage gap * chore: nits refactor * chore: go back to fulfill being onlySlasher * test: fixes from core updates * fix: use delegated stake per operator set instead of per AVS * fix: update to 14 days * feat: configurable lookahead and stake type

src/ServiceManagerBaseStorage.sol

src/StakeRegistry.sol

* feat: remove both option * chore: remove unused test util contracts * chore: remove diff

#317) * feat: remove both option * feat: total delegated stake and total slashable stake per quorum config * test: resolve some breaking changes to tests * chore: move stake type to file level definition * chore: refactor loop * test: add unit test for slashble stake quorum init * test: assert on state and event * test: delegated stake quorum and assertions

supernovahs · 2024-12-04T10:30:48Z

Error (9553): Invalid type for argument in function call. Invalid implicit conversion from contract TransparentUpgradeableProxy to contract ITransparentUpgradeableProxy requested.
   --> lib/eigenlayer-middleware/test/utils/MockAVSDeployer.sol:310:17:
    |
310 |                 TransparentUpgradeableProxy(payable(address(registryCoordinator))),
    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Error: Compilation failed

getitng this while compiling my contracts in IS with this as submodule

supernovahs · 2024-12-04T10:33:00Z

test/mocks/ECDSAServiceManagerMock.sol

+    function registerOperatorToOperatorSets(
+        address operator,
+        uint32[] calldata operatorSetIds,
+        ISignatureUtils.SignatureWithSaltAndExpiry memory operatorSignature
+    ) external {}
+
+    function deregisterOperatorFromOperatorSets(address operator, uint32[] calldata operatorSetIds) external{}


these can be directly called by the operator right? Or is it necessary to route these through service manager?

These have to be routed through the service manager currently, but that will likely change post-UAM

They won't be called directly by the operator on the service manager, though. The flow would be

Registry -> ServiceManager -> AllocationManager

what is UAM?

universal access managemnent

* chore: add note * fix: remove handling of forceDeregistration * fix: fix total delegated stake usage * fix: integration tests * test: fix remaining integration tests * test: add back log check * test: add additional tests for transition to operator sets * test: add more test cases * feat: record m2 quorums on migration * chore: add note about churn support * fix: prevent operator set registration changes for m2 quorums * feat: require strings * chore: add dev note and add require string

* docs: match file and library name, and add docstrings * docs: update error strings to match function * style: forge fmt + moving variables around + fixing error strings * fix: enforce max quorum count for EjectionManager * style: more error string fixes + formatting * fix: correctly set StakeRegistryStorage gap * style: more error string corrections + typos

* fix: withdrawal delay check * fix: add operator set strategies (#334) * fix: remove registerOperatorToOperatorSet interface function * fix: update interface functions with alm interface * fix: operator set strategies in ALM * chore: remove todo * fix: add strategies by stake registry * fix: params for deregister * chore: remove old migration functions * chore: check quorum exists before setting params * fix: deregister flow for operator set quorums * test: fix test for DM withdrawal delay blocks * chore: update all pragmas to 0.8.27 (#336) * feat: custom require errors for registry coordinator (#337) * feat: custom require errors for registry coordinator * ci: update the ci to use the correct compiler settings

src/RegistryCoordinatorStorage.sol

src/RegistryCoordinator.sol

8sunyuan · 2025-01-07T14:47:35Z

src/RegistryCoordinator.sol

+    ) external override onlyWhenNotPaused(PAUSED_REGISTER_OPERATOR) {
+        require(isUsingOperatorSets(), OperatorSetsNotEnabled());
+        for (uint256 i = 0; i < operatorSetIds.length; i++) {
+            require(!isM2Quorum[uint8(operatorSetIds[i])], OperatorSetsNotSupported());


can't we just make isM2Quorum a uint256 and do bitwise and to check this?

don't see a huge benefit of this

src/RegistryCoordinator.sol

8sunyuan · 2025-01-07T15:00:25Z

src/interfaces/IRegistryCoordinator.sol

This interface really should contain the register/registerWithChurn/deregister interfaces.

yeah makes sense

src/RegistryCoordinator.sol

* chore: bump dep * fix: iface changes and param names

* feat: storage reports * fix: storage report * fix: storage report * fix: ci * fix: ci * fix: ci * fix: ci * fix: ci

…tion for checkALM

* refactor: custom errors * fix: unit tests

src/StakeRegistry.sol

8sunyuan · 2025-01-13T14:16:12Z

src/RegistryCoordinator.sol

+    }
+
+    function isUsingOperatorSets() public view returns (bool) {
+        return isOperatorSetAVS;


I think this should just be default to true in the initialize function. OperatorSet quorums should be the new normal as the AVSD is planned to be deprecated in some future release.

8sunyuan · 2025-01-13T14:22:47Z

src/RegistryCoordinator.sol

+        emit OperatorSocketUpdate(operatorId, socket);
+
+        // If the operator wasn't registered for any quorums, update their status
+        // and register them with this AVS in EigenLayer core (DelegationManager)


comment needs updating

ypatil12 · 2025-01-13T14:23:23Z

src/RegistryCoordinator.sol

        SignatureWithSaltAndExpiry memory churnApproverSignature,
        SignatureWithSaltAndExpiry memory operatorSignature
    ) external onlyWhenNotPaused(PAUSED_REGISTER_OPERATOR) {
-        require(operatorKickParams.length == quorumNumbers.length, "RegistryCoordinator.registerOperatorWithChurn: input length mismatch");
-
+        require(!isUsingOperatorSets(), OperatorSetsEnabled());


If we want to enable the same functionality pre and post operatorSets, how do we handle churn once an AVS has started using operatorSets?

8sunyuan · 2025-01-13T14:36:36Z

src/slashers/VetoableSlasher.sol

+        _cancelSlashingRequest(requestId);
+    }
+
+    function fulfillSlashingRequest(uint256 requestId) external virtual onlySlasher {


This modifier is a bit confusing because from the SM perspective this contract is the Slasher but the VetoableSlasher also has a designated slasher address? I guess this can be overrided to be permissionless or to be some other permissioned contract 'slasher'

* refactor: uam * feat: add uam interfaces * fix: lookahead period to blocks * fix: tests * chore: storage report

gpsanant and others added 19 commits July 17, 2024 11:42

Update LICENSE (#285)

7d49b51

chore: upgrade core to target operator set release

163f4c3

Merge branch 'dev' into feat/operate-set-release-branch

ad64a45

chore: update mock contracts with latest interfaces (#293)

b7f4903

* chore: update mock contracts with latest interfaces

chore: bump to latest operator set release commits

d991827

chore: fixes for depedency bump

4966813

chore: bump operator set release dependency in core

e5b2688

chore: updates from dependency bump

ec2fdf3

feat: add natspec

12eda5d

docs: add natspec

788cd09

feat: add checks operator was registered for quorums when migrating

d64f4af

fix: resolve code size issue in RegistryCoordinator

a92d51a

chore: update to latest core (#299)

32148de

* chore: update to latest eigenlayer-contracts feat/operator-set-release * chore: add method to mock

merge dev

3e4cb2b

feat(op sets): upgrade and migrate script (#303)

e0a79f1

* feat: upgrade and test pre prod upgrade and migration * fix: add param introduced in merge

stevennevins changed the title ~~Feat/slashing release branch~~ feat: slashing release Oct 17, 2024

stevennevins added 2 commits October 17, 2024 17:05

wadealexc reviewed Nov 8, 2024

View reviewed changes

src/ServiceManagerBaseStorage.sol Outdated Show resolved Hide resolved

wadealexc reviewed Nov 8, 2024

View reviewed changes

src/StakeRegistry.sol Outdated Show resolved Hide resolved

stevennevins and others added 4 commits November 18, 2024 13:52

chore: remove unused test util contracts (#319)

145bdaf

* feat: remove both option * chore: remove unused test util contracts * chore: remove diff

feat: remove both option

9a975df

fix: storage gap remove one slot (#320)

fa04f06

supernovahs reviewed Dec 4, 2024

View reviewed changes

stevennevins and others added 10 commits December 9, 2024 13:05

chore: bump dependency for slashing mags updates (#329)

6fd466e

Merge branch 'mainnet' into feat/slashing-release-branch

f9ce2fc

fix: revert cases

cb298ea

chore: bump core dependency to pull in latest updates

7307b08

chore: bump core dependency

1cc4983

chore: bump forge-std

44e1a40

docs: update readme with note on slashing (#341)

865b490

8sunyuan reviewed Jan 6, 2025

View reviewed changes

src/RegistryCoordinatorStorage.sol Show resolved Hide resolved

8sunyuan reviewed Jan 7, 2025

View reviewed changes

src/RegistryCoordinator.sol Show resolved Hide resolved

8sunyuan reviewed Jan 7, 2025

View reviewed changes

src/RegistryCoordinator.sol Show resolved Hide resolved

8sunyuan reviewed Jan 7, 2025

View reviewed changes

src/RegistryCoordinator.sol Show resolved Hide resolved

8sunyuan reviewed Jan 7, 2025

View reviewed changes

src/RegistryCoordinator.sol Outdated Show resolved Hide resolved

stevennevins and others added 5 commits January 8, 2025 08:15

chore: bump core fix iface changes (#352)

d54835c

* chore: bump dep * fix: iface changes and param names

feat: ci storage reports (#347)

cbcc0a4

* feat: storage reports * fix: storage report * fix: storage report * fix: ci * fix: ci * fix: ci * fix: ci * fix: ci

fix: prevent calling enable operator sets twice and use internal func…

42fa63e

…tion for checkALM

chore: address review comments

45eb220

refactor: custom errors in middleware (#355)

8778517

* refactor: custom errors * fix: unit tests

8sunyuan reviewed Jan 10, 2025

View reviewed changes

src/StakeRegistry.sol Outdated Show resolved Hide resolved

stevennevins added 2 commits January 10, 2025 16:38

chore: review remove setStakeType

34456b3

fix: wire up stake registry to call add and rm strategies for op set

2246b7d

8sunyuan reviewed Jan 13, 2025

View reviewed changes

ypatil12 reviewed Jan 13, 2025

View reviewed changes

8sunyuan reviewed Jan 13, 2025

View reviewed changes

refactor: slashing UAM (#357)

3b8d801

* refactor: uam * feat: add uam interfaces * fix: lookahead period to blocks * fix: tests * chore: storage report

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: slashing release #311

feat: slashing release #311

stevennevins commented Oct 17, 2024

supernovahs commented Dec 4, 2024

supernovahs Dec 4, 2024

stevennevins Dec 4, 2024

supernovahs Dec 4, 2024

stevennevins Dec 9, 2024

8sunyuan Jan 7, 2025

stevennevins Jan 7, 2025

8sunyuan Jan 7, 2025

stevennevins Jan 7, 2025

8sunyuan Jan 13, 2025

8sunyuan Jan 13, 2025

ypatil12 Jan 13, 2025

8sunyuan Jan 13, 2025

feat: slashing release #311

Are you sure you want to change the base?

feat: slashing release #311

Conversation

stevennevins commented Oct 17, 2024

supernovahs commented Dec 4, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment