feat: from scratch scripts #335
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevennevins
changed the base branch from
mainnet
to
feat/slashing-release-branch
* fix: remove registerOperatorToOperatorSet interface function * fix: update interface functions with alm interface * fix: operator set strategies in ALM * chore: remove todo * fix: add strategies by stake registry * fix: params for deregister * chore: remove old migration functions * chore: check quorum exists before setting params * fix: deregister flow for operator set quorums
* feat: custom require errors for registry coordinator * ci: update the ci to use the correct compiler settings
stevennevins
changed the base branch from
feat/slashing-release-branch
to
fix/slashing-release-branch-1
Base automatically changed from
fix/slashing-release-branch-1
to
feat/slashing-release-branch
December 16, 2024 14:25
ypatil12
reviewed
Jan 15, 2025
8sunyuan
reviewed
Jan 17, 2025
| struct DeploymentData { | ||
| address delegationManager; | ||
| address avsDirectory; | ||
| address allocationManager; |
There was a problem hiding this comment.
AllocationManagerConfig seems to be missing
8sunyuan
reviewed
Jan 17, 2025
| addrs.avsDirectoryImpl, | ||
| addrs.strategyManagerImpl, | ||
| addrs.strategyFactoryImpl | ||
| ) = _deployMainImplementations(result, config); |
There was a problem hiding this comment.
ALM also seems to be missing from _deployMainImplementations and _deployRemainingImplementations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.