Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Signer tests #373

Merged
merged 5 commits into from
Oct 18, 2024
Merged

Add Signer tests #373

merged 5 commits into from
Oct 18, 2024

Conversation

TomasArrachea
Copy link
Contributor

Add Signer tests

Reviewer Checklist

  • Code is well-documented
  • Code adheres to Go naming conventions
  • Code deprecates any old functionality before removing it

@TomasArrachea TomasArrachea changed the title WIP Add Signer tests Add Signer tests Oct 7, 2024
@TomasArrachea TomasArrachea marked this pull request as ready for review October 7, 2024 19:03
Copy link
Contributor

@pablodeymo pablodeymo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@pablodeymo pablodeymo requested a review from afkbyte October 7, 2024 19:28
@pablodeymo pablodeymo added the maintenance version next maintenance version label Oct 14, 2024
@afkbyte afkbyte added this pull request to the merge queue Oct 18, 2024
Merged via the queue into dev with commit c8f841d Oct 18, 2024
4 checks passed
@afkbyte afkbyte deleted the signer_tests branch October 18, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance version next maintenance version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants