test: chainReader shares and operatorSets functions
#437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| const allocationDelay = 1 | ||
| const allocationMagnitude = 100 | ||
| const allocationConfigurationDelay = 1200 |
There was a problem hiding this comment.
These constants should be outside the test or else they can be variables.
| true, | ||
| ) | ||
| require.NoError(t, err) | ||
| require.Equal(t, uint64(1), receipt.Status) |
There was a problem hiding this comment.
This literal can be replaced for gethtypes.ReceiptStatusSuccessful
| opSets, err := chainReader.GetOperatorSetsForOperator(context.Background(), operatorAddr) | ||
| require.NoError(t, err) | ||
| require.NotEmpty(t, opSets) | ||
| require.Len(t, opSets, 1) |
There was a problem hiding this comment.
If opSets has len 1 then it is not empty, so one require is redundant in my opinion
| operators, err := chainReader.GetOperatorsForOperatorSet(context.Background(), operatorSet) | ||
| require.NoError(t, err) | ||
| require.NotEmpty(t, operators) | ||
| require.Len(t, operators, 1) |
pablodeymo
approved these changes
Jan 20, 2025
maximopalopoli
pushed a commit
to lambdaclass/eigensdk-go
that referenced
this pull request
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Changed?
This PR aims to increase the test coverage of
reader.go.Tested functions:
GetOperatorsForOperatorSetGetNumOperatorsForOperatorSetGetOperatorSetsForOperatorGetNumOperatorSetsForOperatorGetStrategiesForOperatorSetGetSlashableSharesGetSlashableSharesForOperatorSetsGetSlashableSharesForOperatorSetsBeforeGetRegisteredSetsIncreased the test timeout from 4 minutes to 5 minutes.
Reviewer Checklist