-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add invalid config chainWriter tests #454
test: add invalid config chainWriter tests #454
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments regarding the address values. I think it would be better to use constants instead of literals when we know the addresses come from Anvil.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What Changed?
The goal is to increase the test coverage of chain writer, by testing those cases of passing an invalid config so the contracts addresses are set as nil and the initial validations of the methods will fail.
Increases test coverage of
chainio/clients/elcontracts/writer.go
up to 79.2%.Reviewer Checklist