Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: add job to check the bindings are up to date #475

Merged
merged 29 commits into from
Jan 30, 2025
Merged

ci: add job to check the bindings are up to date #475

merged 29 commits into from
Jan 30, 2025

Conversation

ricomateo
Copy link
Contributor

@ricomateo ricomateo commented Jan 27, 2025 •
edited
Loading

Fixes #474

What Changed?

This PR introduces the following changes:

  • Adds a CI job that checks the bindings in two ways:
    • Checks the bindings can be generated (this required a change in the eigenlayer-contracts URL in chainio/clients/eigenpod/generate.sh to an https URL so that it can be cloned in the CI job without setting an SSH key).
    • Checks the bindings are up to date (only when the contracts have been changed).

Reviewer Checklist

  • Code is well-documented
  • Code adheres to Go naming conventions
  • Code deprecates any old functionality before removing it

@ricomateo ricomateo self-assigned this Jan 27, 2025
@ricomateo ricomateo force-pushed the check-bindings-in-ci branch from 110b98e to c59e338 Compare January 27, 2025 19:25
@ricomateo ricomateo changed the base branch from dev to update-bindings January 27, 2025 19:28
@ricomateo ricomateo marked this pull request as ready for review January 27, 2025 21:45
MegaRedHand
MegaRedHand reviewed Jan 28, 2025
View reviewed changes
.github/workflows/bindings.yml Outdated Show resolved Hide resolved
.github/workflows/bindings.yml Outdated Show resolved Hide resolved
.github/workflows/bindings.yml Outdated Show resolved Hide resolved
MegaRedHand
MegaRedHand previously approved these changes Jan 28, 2025
View reviewed changes
Base automatically changed from update-bindings to dev January 29, 2025 18:58
@ricomateo ricomateo dismissed MegaRedHand’s stale review January 29, 2025 18:58

The base branch was changed.

@ricomateo ricomateo enabled auto-merge January 29, 2025 19:00
@ricomateo ricomateo marked this pull request as draft January 29, 2025 21:04
auto-merge was automatically disabled January 29, 2025 21:04

Pull request was converted to draft

@ricomateo ricomateo marked this pull request as ready for review January 30, 2025 16:01
@ricomateo ricomateo enabled auto-merge January 30, 2025 16:18
@ricomateo ricomateo added this pull request to the merge queue Jan 30, 2025
Merged via the queue into dev with commit 4286221 Jan 30, 2025
8 checks passed
@ricomateo ricomateo deleted the check-bindings-in-ci branch January 30, 2025 16:24
@MegaRedHand MegaRedHand mentioned this pull request Feb 7, 2025
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablodeymo pablodeymo pablodeymo approved these changes

@MegaRedHand MegaRedHand MegaRedHand left review comments

Assignees

@ricomateo ricomateo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check bindings are up to date in CI
3 participants
@ricomateo @pablodeymo @MegaRedHand