Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: change provider value used by avs_reader in tests #306

Merged
merged 8 commits into from
Feb 7, 2025
Merged

fix: change provider value used by avs_reader in tests #306

merged 8 commits into from
Feb 7, 2025

Conversation

damiramirez
Copy link

@damiramirez damiramirez commented Feb 5, 2025 •
edited by MegaRedHand
Loading

What Changed?

In avsregistry/reader, we are testing against Holesky. The idea is to run tests locally against Anvil. The method that constructs avs_reader has been modified.

When making the change, it generated a problem in the tests and so a temporary fix was added. Related issue #307

Reviewer Checklist

  • New features are tested and documented
  • PR updates the changelog with a description of changes
  • PR has one of the changelog-X labels (if applies)
  • Code deprecates any old functionality before removing it

@damiramirez damiramirez changed the title fix: change prov fix: change provider value used by avs_reader in tests Feb 5, 2025
@damiramirez damiramirez mentioned this pull request Feb 5, 2025
Open
MegaRedHand
MegaRedHand approved these changes Feb 6, 2025
View reviewed changes
Copy link
Contributor

@MegaRedHand MegaRedHand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can probably be fixed by doing a stake update in the AVS. We should revisit this later.

@damiramirez damiramirez marked this pull request as ready for review February 6, 2025 13:20
@damiramirez damiramirez force-pushed the fix/change-holesky-anvil branch from 6b619db to aed488d Compare February 7, 2025 20:21
@MegaRedHand MegaRedHand added the changelog-ignore PR is allowed to skip the changelog label Feb 7, 2025
@MegaRedHand MegaRedHand merged commit 91d6f18 into Layr-Labs:dev Feb 7, 2025
10 of 11 checks passed
@MegaRedHand MegaRedHand deleted the fix/change-holesky-anvil branch February 7, 2025 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablodeymo pablodeymo pablodeymo approved these changes

@MegaRedHand MegaRedHand MegaRedHand approved these changes

Assignees
No one assigned
Labels
changelog-ignore PR is allowed to skip the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@damiramirez @pablodeymo @MegaRedHand