Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using reusable workflows to trigger all C apps build #844

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lpascal-ledger
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.43%. Comparing base (69fe88c) to head (0fc2872).
Report is 8 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #844       +/-   ##
===========================================
+ Coverage   35.49%   60.43%   +24.94%     
===========================================
  Files          13       13               
  Lines        1606     1820      +214     
===========================================
+ Hits          570     1100      +530     
+ Misses       1036      720      -316     
Flag Coverage Δ
unittests 60.43% <ø> (+24.94%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@tdejoigny-ledger tdejoigny-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good simplification!
Is it possible to display more clearly in the CI which app is being built? Like here for example: https://github.com/LedgerHQ/ledger-secure-sdk/actions/runs/12926890555/job/36051308952

Furthermore, we need to ensure that the apps built with the old CI are the same as those built with this new version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants