-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #51 유니크 추가 및 post send 구현 #51
base: dev
Are you sure you want to change the base?
The head ref may contain hidden characters: "fix/#46/\uC720\uB2C8\uD06C-\uCD94\uAC00-postSend"
Changes from 4 commits
e3d4812
194b747
fb7856f
6a5a061
4c30106
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -10,4 +10,6 @@ public interface StompCommandStrategy { | |
boolean supports(StompCommand command); | ||
|
||
Message<?> preSend(Message<?> message, StompHeaderAccessor accessor, MessageChannel channel); | ||
|
||
void postSend(Message<?> message, StompHeaderAccessor accessor, MessageChannel channel, boolean sent); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
다만, 다른 stomp전략들이 postSend가 필요하다면 상관없을 거 같습니다! There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. StompSubscribeStrategy 이외에도 postSend를 항상 override 해줘야한다는 점에서 저도 우석님의 의견처럼 추가적인 인터페이스 분리가 오히려 복잡성을 높일 수도 있지 않을까라는 생각이 있긴합니다, There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 차후에 다른 전략에서도 postSend를 사용해야하는 경우가 생긴다면 StompCommandStrategy 내부에서 preSend, postSend 2가지 메서드를 공통으로 관리하여 하위 전략들이 하나의 인터페이스를 구현하는게 관리가 용이할 것 같다는 생각이 들었습니다! 그래서 현재는 StompCommandStrategy 내에 defalut 메서드로 구현을 해서 StompSubscribeStrategy 만 재정의를 해서 구현을 하고, 차후 필요에 의해 다른 전략에서도 postSend를 구현한다면 메서드만 재정의하면 되니까 추가 코드 없이 확장이 될 것 같은데 여러 분들 의견은 어떠신가요?? 일단 수정한 버전으로 푸시 해두겠습니다! |
||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
멤버와 채팅방을 유니크로 묶었군요!!
데이터 무결성이 더 잘 지켜질 것 같습니당!!👍