+61
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soyesenna
approved these changes
Jan 28, 2025
| String key = getKey(roomId); | ||
|
|
||
| chatRoomRedisTemplate.opsForSet().add(key, senderId); | ||
| chatRoomRedisTemplate.opsForHash().put(key, String.valueOf(senderId), profilePicture); |
There was a problem hiding this comment.
사진도 함께 저장하는군요!!
좋은 방식인 것 같습니다!!
| } | ||
|
|
||
| return size; | ||
| return profileImageUrl.toString(); |
There was a problem hiding this comment.
return profileImageUrl == null ? null : profileImageUrl.toString()
위의 코드로 바꾸는건 어떻게 생각하시나요??
개인적으로 로직이 조금 더 한 눈에 보이는 것 같습니당!!
There was a problem hiding this comment.
Optional을 이용해서 아래와같이 수정해봤는데 이건 어떠세용??
return Optional.ofNullable(chatRoomRedisTemplate.opsForHash().get(key, String.valueOf(senderId)))
.map(Object::toString)
.orElse(null);
huncozyboy
reviewed
Jan 30, 2025
| String key = getKey(roomId); | ||
|
|
||
| chatRoomRedisTemplate.opsForSet().add(key, senderId); | ||
| chatRoomRedisTemplate.opsForHash().put(key, String.valueOf(senderId), profilePicture); |
There was a problem hiding this comment.
기존 opsForSet을 활용하여 사용자 정보를 저장하던 방식을 opsForHash를 사용해서 사용자의 프로필 사진을 함께 저장하는 로직으로 변경된걸 확인했습니다 !
동시에 opsForHash를 사용할 경우에 관련 데이터가 삭제될때((매칭 종료 이후나 사용자에 의해 채팅방 퇴장), 올바르게 삭제 로직이 이루어지는지 테스트가 필요해보입니다
There was a problem hiding this comment.
이벤트 리스너를 구현을 해서, 웹소켓 구독 해제시 데이터가 제거 되도록 구현했고, 테스트도 완료했습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 관련 이슈
관련 이슈 번호 #47
Close #
🚀 작업 내용
📸 스크린샷
📢 리뷰 요구사항