Skip to content

Commit

Permalink
fix tanstack query plugin wasn't passing through all the other synced…
Browse files Browse the repository at this point in the history
… props
  • Loading branch information
jmeistrich committed Jun 10, 2024
1 parent 328d996 commit 74a3242
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
5 changes: 3 additions & 2 deletions src/sync-plugins/tanstack-query.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ export interface ObservableQueryOptions<TQueryFnData, TError, TData, TQueryKey e
}

export interface SyncedQueryParams<TQueryFnData, TError, TData, TQueryKey extends QueryKey>
extends SyncedOptions<TData> {
extends Omit<SyncedOptions<TData>, 'get' | 'set'> {
queryClient: QueryClient;
query: ObservableQueryOptions<TQueryFnData, TError, TData, TQueryKey>;
mutation?: MutationObserverOptions<TData, TError, void>;
Expand All @@ -30,7 +30,7 @@ export function syncedQuery<
TData = TQueryFnData,
TQueryKey extends QueryKey = QueryKey,
>(params: SyncedQueryParams<TQueryFnData, TError, TData, TQueryKey>) {
const { query: options, mutation: mutationOptions, queryClient } = params;
const { query: options, mutation: mutationOptions, queryClient, ...rest } = params;

const Observer = QueryObserver;
const defaultedOptions = queryClient!.defaultQueryOptions(
Expand Down Expand Up @@ -109,5 +109,6 @@ export function syncedQuery<
get,
set,
subscribe,
...rest,
});
}
2 changes: 1 addition & 1 deletion src/sync-plugins/tanstack-react-query.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,6 @@ export function useObservableSyncedQuery<
TError = DefaultError,
TData = TQueryFnData,
TQueryKey extends QueryKey = QueryKey,
>(params: SyncedQueryParams<TQueryFnData, TError, TData, TQueryKey>): Observable<NonNullable<Synced<TData>>> {
>(params: SyncedQueryParams<TQueryFnData, TError, TData, TQueryKey>): Observable<Synced<TData>> {
return useObservable(syncedQuery(params));
}

0 comments on commit 74a3242

Please sign in to comment.