Try solving computed immediate with sideEffects: false

LegendApp · Nov 8, 2023 · a8a8a2c · a8a8a2c
1 parent c6453ac
commit a8a8a2c
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/src/ObservableObject.ts b/src/ObservableObject.ts
@@ -1007,7 +1007,7 @@ const activateNodeBase = (globalState.activateNode = function activateNodeBase(
     let isSettingFromSubscribe = false;
     let _mode: 'assign' | 'set' = 'set';
     if (node.activationState) {
-        const { onSet, subscribe, get, initial, retry, waitFor } = node.activationState;
+        const { onSet, subscribe, get, initial, retry, waitFor, sideEffects } = node.activationState;
         // @ts-expect-error asdf
         const run = () => get!({ updateLastSync: noop, setMode: (mode) => (_mode = mode) });
         value = get
@@ -1063,7 +1063,7 @@ const activateNodeBase = (globalState.activateNode = function activateNodeBase(
                 }
             };
 
-            onChange(node, doSet as any, wasPromise ? undefined : { immediate: true });
+            onChange(node, doSet as any, sideEffects === false || wasPromise ? undefined : { immediate: true });
         }
         if (process.env.NODE_ENV === 'development' && node.activationState!.cache) {
             // TODO Better message

diff --git a/src/observableInterfaces.ts b/src/observableInterfaces.ts
@@ -151,6 +151,7 @@ export interface ActivateParams<T = any> {
     get?: (params: ActivateGetParams) => T;
     retry?: RetryOptions;
     mode?: 'assign' | 'set' | 'dateModified';
+    sideEffects?: boolean;
 }
 // eslint-disable-next-line @typescript-eslint/no-unused-vars
 export interface ActivateParamsWithLookup<T extends Record<string, any> = Record<string, any>>