-
-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add expo-sqlite/kv-store persist plugin #413
Conversation
This looks great! I wonder about a couple of things:
Does that make sense? Please let me know if I can help with anything! |
Hey @catalinmiron do you want to look into those changes and then we can merge this in? Or if you're too busy I can make those changes on top of the PR and go for merge. I'm very excited to get this in! |
@jmeistrich Happy New Year! I was semi offline during the Holidays. I am going to take another look at it next week. I know that the kv-store has the sync API available but I was not sure if everything was exposed as sync (multiGet may not be sync) but I will look into mmkv implementation as well. I'll ping you if I have any issues maybe you can unblock me. Thanks! |
Ok great! Hope you had a good holiday 😁 |
…ther than the full value
…ys or by setting a new object with missing keys
…o an array in some cases
@jmeistrich I've made the changes, tested locally and everything works. PS: I don't know what happened to the PR (merged the main branch and it exploded 🤯 ) -> I can open a different one if this is too much noise. export const persistOptions = configureSynced({
persist: {
plugin: observablePersistSqlite(new SQLiteStorage("myOtherSQLiteDatabase")),
},
}); |
Awesome, this looks great now! But yes the PR seems to have exploded 😂. It looks like it's reverting a bunch of core changes. So can you clear the branch up somehow or just make a new PR? Then I think it looks good to merge. |
Add
expo-sqlite/kv-store
to the persist plugins list.More about the [expo-sqlite/kv-store])(https://docs.expo.dev/versions/latest/sdk/sqlite/#key-value-storage)