Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Fleet Initial Theme Definition #6

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ennerperez
Copy link
Collaborator

No description provided.

@LegoYoda112
Copy link
Owner

Woah thanks for a full theme addition! I'll add you as a maintainer on the repo to let you merge this into the dev branch and verify the build system works.

I'll need to think through the deployment process a bit if we're going to add more apps to this; the two ways I can think of doing it for now are:

  • having a branch for each deployment so we can separate when they run, or,
  • have some logic on the main branch that only runs the deployments for themes that have their version incremented (e.g. vsce, the vscode tool, only uploads the package if the source version has been incremented relative to the published version and throws an error otherwise, a bit hacky to rely on, but it would work).

I'm somewhat new to CD systems to any advice is appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants